The
Noldor.
Their acomplishments far outweigh their shortcomings (notwithstanding the Kinslaying, in which not all Noldor took part). The Holy Jewels, the
realms in
Beleriand,
Nargothrond and
Gondolin.
Fingolfin himself, the only Elda to actually wound
Morgoth.
Galadriel, while a half-Teleri she is considered to be a Noldo, is probably the most powerful female
Elf in the entire saga.
The
Vanyar are in total bliss, all the time, so they have little to challenge them, spurring them on to great deeds. The Teleri are waverers and fearful, far to absorbed their pastoral lives.
The
Sindar, OTOH, are in my opinion a close second to the Noldor, though like their Telerin cousins, prefer to be left alone. Some like Beleg were great heros in their own right, others were no less important for their part, such as Eol.
Celeborn was a noble
Sindarin Lord. Then there's great King
Thingol himself, though not exactly a Sinda. His descendants were also important Sindar:
Luthien and Dior, Elwing.